Performance improvement for DefaultConverter.convertToJSONPrimitive() #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out it's much more efficient to avoid exceptions when trying alternatives types in
DefaultConverter.convertToJSONPrimitive()
. Instead we can do a bit of character parsing to more efficiently find the type before attempting to do the exception-throwingX.parseX()
.The results on a 2019 Intel Macbook Pro for the following test code (which loops through a variety of test data 1000000 times) are:
Before: 27.31s
After: 0.76s
... which seems worth doing!
Test code: