Fixes #10120 - OOME due to HttpChannelState._onIdleTimeout

When `HttpChannelState._onIdleTimeout` was introduced, it was forgotten to null it out in recycle(). Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
jetty · Jul 18, 2023 · abc01d5 · abc01d5
1 parent c946a41
commit abc01d5
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/...y-core/jetty-server/src/main/java/org/eclipse/jetty/server/internal/HttpChannelState.java b/...y-core/jetty-server/src/main/java/org/eclipse/jetty/server/internal/HttpChannelState.java
@@ -149,22 +149,23 @@ public void recycle()
             // applications cannot use request/response/callback anymore.
             _request._httpChannelState = null;
 
-            // Break the links with the upper and lower layers.
-            _request = null;
-            _response = null;
-            _stream = null;
-            _streamSendState = StreamSendState.SENDING;
-
             // Recycle.
             _responseHeaders.reset();
             _handling = null;
             _handled = false;
+            _streamSendState = StreamSendState.SENDING;
             _callbackCompleted = false;
-            _callbackFailure = null;
+            _request = null;
+            _response = null;
+            _oldIdleTimeout = 0;
+            // Break the link between channel and stream.
+            _stream = null;
             _committedContentLength = -1;
             _onContentAvailable = null;
+            _onIdleTimeout = null;
             _failure = null;
             _onFailure = null;
+            _callbackFailure = null;
         }
     }