Skip to content

Commit

Permalink
Fix memory leak in GzipHandler
Browse files Browse the repository at this point in the history
Looks like this leak shows itself only with asynchronous responses.

Some relevant info: http://www.devguli.com/blog/eng/java-deflater-and-outofmemoryerror/

Signed-off-by: Denis Nedelyaev <denvned@gmail.com>
  • Loading branch information
denvned committed Mar 27, 2017
1 parent c366934 commit ddf8ec8
Showing 1 changed file with 6 additions and 1 deletion.
Expand Up @@ -610,9 +610,14 @@ protected boolean isPathGzipable(String requestURI)
@Override
public void recycle(Deflater deflater)
{
deflater.reset();
if (_deflater.get()==null)
{
deflater.reset();
_deflater.set(deflater);
}
else {
deflater.end();
}
}

/* ------------------------------------------------------------ */
Expand Down

0 comments on commit ddf8ec8

Please sign in to comment.