Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocket ClosedChannelException when demanding frames in onOpen #11398

Closed
lachlan-roberts opened this issue Feb 13, 2024 · 0 comments · Fixed by #11402
Closed

WebSocket ClosedChannelException when demanding frames in onOpen #11398

lachlan-roberts opened this issue Feb 13, 2024 · 0 comments · Fixed by #11402
Assignees
@lachlan-roberts
Labels
Bug For general bugs on Jetty side

Comments

@lachlan-roberts
Copy link
Contributor

Jetty version(s)
12

How to reproduce?
For the FrameHandler.onOpen event, the callback is used to transition from state CONNECTED to OPEN. When you receive the onOpen notification in the Jetty WebSocket API the callback has not been completed and the session is in state CONNECTED. If the application then demands from onOpen a frame could be delivered before the callback is complete and throws a CloseChannelException because the session is not input open yet.
@lachlan-roberts lachlan-roberts added the Bug For general bugs on Jetty side label Feb 13, 2024
@lachlan-roberts lachlan-roberts self-assigned this Feb 13, 2024
lachlan-roberts added a commit that referenced this issue Feb 14, 2024
@lachlan-roberts
Issue #11398 - allow frames to be demanded in WebSocket onOpen
25fb7be 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts mentioned this issue Feb 14, 2024
Merged
lachlan-roberts added a commit that referenced this issue Feb 15, 2024
@lachlan-roberts
Issue #11398 - do not deliver messages until onOpen completes
783c14c 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Feb 27, 2024
@lachlan-roberts
Merge pull request #11402 from jetty/jetty-12.0.x-11398-WebSocket-Clo…
d3f19bb 
…seChannelException

Issue #11398 - allow frames to be demanded in WebSocket onOpen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
Bug For general bugs on Jetty side
Projects
No open projects
Jetty 12.0.7 - FROZEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #11398 - allow frames to be demanded in WebSocket onOpen jetty/jetty.project
1 participant
@lachlan-roberts