Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add it test for Maven Plugin #1638

Closed
olamy opened this issue Jun 21, 2017 · 7 comments
Closed

Add it test for Maven Plugin #1638

olamy opened this issue Jun 21, 2017 · 7 comments
Assignees
Labels

Comments

@olamy
Copy link
Member

olamy commented Jun 21, 2017

the goal is to have it test for each mojo

@olamy
Copy link
Member Author

olamy commented Jun 21, 2017

@WalkerWatch please assign to me

@olamy
Copy link
Member Author

olamy commented Jun 23, 2017

@janbartel I have a branch with the it tests here https://github.com/olamy/jetty.project/tree/feature/maven_plugin_its
ATM fragment doesn't work but forked has been fixed.

@olamy
Copy link
Member Author

olamy commented Jun 23, 2017

@janbartel
Copy link
Contributor

@olamy now that @joakime merged pr #1644 should this issue be closed, or is there more to do?

@joakime
Copy link
Contributor

joakime commented Jul 13, 2017

There's something up with the testcases in master.
https://jenkins.webtide.net/job/jetty.project/job/master/363/testReport/

Probably a bad merge. :-(

@olamy
Copy link
Member Author

olamy commented Jul 13, 2017

ok I will have a look on master branch

@olamy
Copy link
Member Author

olamy commented Jul 17, 2017

well it looks master has a lot changes which cause a lot of failure in the maven plugin.
So it's not simply a bad merge!
Working on it. Well finally a good idea to add some tests :-)
I guess we can close this one. I have created #1670 to track issues with master.

@olamy olamy closed this as completed Jul 17, 2017
joakime pushed a commit that referenced this issue Jul 29, 2017
Signed-off-by: olivier lamy <olamy@webtide.com>
joakime pushed a commit that referenced this issue Jul 29, 2017
Signed-off-by: olivier lamy <olamy@webtide.com>
joakime pushed a commit that referenced this issue Aug 8, 2017
Signed-off-by: olivier lamy <olamy@webtide.com>
joakime pushed a commit that referenced this issue Aug 8, 2017
Signed-off-by: olivier lamy <olamy@webtide.com>
@joakime joakime added the Test label May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants