Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review HouseKeeper locking #5081

Closed
sbordet opened this issue Jul 27, 2020 · 0 comments · Fixed by #5099
Closed

Review HouseKeeper locking #5081

sbordet opened this issue Jul 27, 2020 · 0 comments · Fixed by #5099
Assignees
@janbartel
Labels
Low Priority

Comments

@sbordet
Copy link
Contributor

sbordet commented Jul 27, 2020 •
edited
Loading

Spawned by #5083.

Jetty version
9.4.x

Description
Review HouseKeeper locking.
Especially, startScavenging() cannot be called right after stopScavenging() because it needs the call to findScheduler() which is not using any locking.

Concurrent calls to setIntervalSec() should atomically either start or stop the scavenging.
@sbordet sbordet mentioned this issue Jul 28, 2020
Closed
janbartel added a commit that referenced this issue Jul 29, 2020
@janbartel
Issue #5081 HouseKeeper synchronization
1f4a280 
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Jul 29, 2020
@janbartel
Issue #5081 Tidy up
6849c54 
Signed-off-by: Jan Bartel <janb@webtide.com>
@janbartel janbartel mentioned this issue Jul 29, 2020
Merged
@janbartel janbartel linked a pull request Jul 29, 2020 that will close this issue
Issue #5081 - HouseKeeper synchronization #5099
Merged
janbartel added a commit that referenced this issue Aug 3, 2020
@janbartel
Issue #5081 Changes after review
cc68ed7 
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Aug 4, 2020
@janbartel
Issue #5081 Fix test
6df5074 
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Aug 5, 2020
@janbartel
Issue #5081 - HouseKeeper synchronization (#5099)
4f57810 
* Issue #5081 HouseKeeper synchronization

Signed-off-by: Jan Bartel <janb@webtide.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janbartel janbartel

Labels
Low Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #5081 - HouseKeeper synchronization jetty/jetty.project
2 participants
@janbartel @sbordet