Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Scanner locking #5086

Closed
sbordet opened this issue Jul 28, 2020 · 0 comments · Fixed by #5744
Closed

Review Scanner locking #5086

sbordet opened this issue Jul 28, 2020 · 0 comments · Fixed by #5744
Assignees
@janbartel
Projects
Jetty 10.0.0

Comments

@sbordet
Copy link
Contributor

sbordet commented Jul 28, 2020

Jetty version
9.4.x

Description
Scanner needs a review regarding synchronization/locking.
Many methods have the synchronized modifier, and other methods that access the same fields don't synchronize.
Also, listeners are sometimes called with the lock held, etc.

This issue should be resolved after #5083.
@sbordet sbordet mentioned this issue Jul 28, 2020
Closed
@sbordet sbordet changed the title Review Scanner synchronization Review Scanner locking Jul 28, 2020
@janbartel janbartel self-assigned this Nov 30, 2020
janbartel added a commit that referenced this issue Dec 1, 2020
@janbartel
Issue #5086 Review and rework o.e.j.util.Scanner
4883332 
Signed-off-by: Jan Bartel <janb@webtide.com>
@janbartel janbartel mentioned this issue Dec 1, 2020
Merged
janbartel added a commit that referenced this issue Dec 1, 2020
@janbartel
Issue #5086 Improve ScannerTest
4304c78 
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Dec 1, 2020
@janbartel
Issue #5086 Fix checkstyle in test
115a72d 
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Dec 1, 2020
@janbartel
Issue #5086 Fix javadoc
90e48ba 
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Dec 1, 2020
@janbartel
Issue #5086 Changes after review
31cc298 
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Dec 2, 2020
@janbartel
Issue #5086 Fix error on addFile
e39ec6c 
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Dec 2, 2020
@janbartel
Issue #5086 Add blocking method for immediate scan.
8fe8cb8 
Signed-off-by: Jan Bartel <janb@webtide.com>
@sbordet sbordet added this to To Do in Jetty 10.0.0 via automation Dec 2, 2020
@sbordet sbordet moved this from To Do to In Review in Jetty 10.0.0 Dec 2, 2020
Jetty 10.0.0 automation moved this from In Review to Done Dec 2, 2020
sbordet added a commit that referenced this issue Dec 2, 2020
@sbordet
Merge pull request #5744 from eclipse/jetty-10.0.x-5086-review-scanner
0eccdde 
Issue #5086 Review and rework o.e.j.util.Scanner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janbartel janbartel

Labels
None yet
Projects
No open projects
Jetty 10.0.0
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #5086 Review and rework o.e.j.util.Scanner jetty/jetty.project
2 participants
@janbartel @sbordet