Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test: HttpOutputTest.testEmptyBufferKnown #6605

Closed
lorban opened this issue Aug 12, 2021 · 0 comments · Fixed by #6606 or #6651
Closed

Flaky test: HttpOutputTest.testEmptyBufferKnown #6605

lorban opened this issue Aug 12, 2021 · 0 comments · Fixed by #6606 or #6651
Assignees
@lorban
Labels
Bug For general bugs on Jetty side Test
Projects
Jetty 9.4.44 FROZEN

Comments

@lorban
Copy link
Contributor

lorban commented Aug 12, 2021 •
edited

Jetty version(s)
9.4.x

Description
HttpOutputTest.testEmptyBufferKnown fails about 1 of every 20 times on the following assertion:

assertThat(committed.get(), is(false));
@lorban lorban added Bug For general bugs on Jetty side Test labels Aug 12, 2021
@lorban lorban self-assigned this Aug 12, 2021
@lorban lorban added this to To do in Jetty 9.4.44 FROZEN via automation Aug 12, 2021
lorban added a commit that referenced this issue Aug 12, 2021
@lorban
#6605 testEmptyBufferKnown: make sure the assertion does not happen …
83b6c21 
…before the committed flag is read

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban mentioned this issue Aug 12, 2021
Merged
@lorban lorban linked a pull request Aug 12, 2021 that will close this issue
Fix flaky HttpOutputTest.testEmptyBufferKnown #6606
Merged
lorban added a commit that referenced this issue Aug 12, 2021
@lorban
#6605 testEmptyBufferKnown: make sure the assertion does not happen …
42a0bbc 
…before the committed flag is read

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Aug 12, 2021
@lorban
#6605 rename test
bdd8a10 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Aug 13, 2021
@lorban
#6605 testEmptyBufferKnown: make sure the assertion does not happen …
4857372 
…before the committed flag is read

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Aug 13, 2021
@lorban
#6605 rename test
cbc814e 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
olamy pushed a commit that referenced this issue Aug 22, 2021
@lorban @olamy
#6605 testEmptyBufferKnown: make sure the assertion does not happen …
a3b74e9 
…before the committed flag is read

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
olamy pushed a commit that referenced this issue Aug 22, 2021
@lorban @olamy
#6605 rename test
7039f56 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@olamy olamy mentioned this issue Aug 22, 2021
Merged
olamy added a commit that referenced this issue Aug 28, 2021
@olamy @lorban
Issue #6605 cherry-pick changes flaky test HttpOutputTest#testEmptyBu…
4be1e63 
…fferKnown 10.0.x branch (#6651)

* #6605 testEmptyBufferKnown: make sure the assertion does not happen before the committed flag is read

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

* #6605 rename test

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

Co-authored-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban closed this as completed Aug 31, 2021
Jetty 9.4.44 FROZEN automation moved this from To do to Done Aug 31, 2021
@lorban lorban linked a pull request Aug 31, 2021 that will close this issue
Issue #6605 cherry-pick changes flaky test HttpOutputTest#testEmptyBufferKnown 10.0.x branch #6651
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorban lorban

Labels
Bug For general bugs on Jetty side Test
Projects
No open projects
Jetty 9.4.44 FROZEN
Done
Milestone
No milestone
1 participant
@lorban