Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate LocalConnector.getResponses() in favor of using .getResponse() #695

Closed
joakime opened this issue Jul 6, 2016 · 1 comment
Closed

Deprecate LocalConnector.getResponses() in favor of using .getResponse() #695

joakime opened this issue Jul 6, 2016 · 1 comment
Labels
Enhancement Task
Milestone
9.4.x

Comments

@joakime
Copy link
Contributor

joakime commented Jul 6, 2016

The current implementation of LocalConnector.getResponses() does a few hokey things related to detecting when a connection is done / closed / no more requests.

The better .getResponse() method is simpler and doesn't contain this extra logic that is slowing down tests and producing rogue errors.
@gregw gregw added this to the 9.4.x milestone Jul 7, 2016
gregw added a commit that referenced this issue Jul 7, 2016
@gregw
Issue #695 improve getResponse methods
183e3ac
gregw added a commit that referenced this issue Jul 7, 2016
@gregw
Issue #695 use the getResponse methods
e38ec83
joakime added a commit that referenced this issue Jul 8, 2016
@joakime
Issue #695 - Flagging with method level @deprecated for improved IDE …
369a105 
…experience
@gregw
Copy link
Contributor

gregw commented Dec 1, 2016

this is ongoing replacement of a deprecated API. No need for an open issue.

@gregw gregw closed this as completed Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Task
Projects
None yet
Milestone
9.4.x
Development

No branches or pull requests
2 participants
@gregw @joakime