Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Spec ServerContainer.upgrade() API #6965

Closed
joakime opened this issue Oct 6, 2021 · 0 comments · Fixed by #6968 or #6967
Closed

Expose Spec ServerContainer.upgrade() API #6965

joakime opened this issue Oct 6, 2021 · 0 comments · Fixed by #6968 or #6967
Assignees
Labels
Enhancement Specification For all industry Specifications (IETF / Servlet / etc)

Comments

@joakime
Copy link
Contributor

joakime commented Oct 6, 2021

Jetty version(s)
9.4.x +

Description

The upcoming jakarta.websocket.server.ServerContainer.upgradeHttpToWebSocket(Object httpServletRequest, Object httpServletResponse, ServerEndpointConfig sec, Map<String,String> pathParameters)
from jakartaee/websocket#375 has shown industry adoption of this API in other containers.

spring-framework is using this pattern for all other containers (glassfish, tyrus, tomcat, undertow, weblogic, and websphere currently).
We need to implement this all the way back to Jetty 9.4.x.

@joakime joakime added Enhancement Bug For general bugs on Jetty side Specification For all industry Specifications (IETF / Servlet / etc) labels Oct 6, 2021
@joakime joakime changed the title Expose Spec ServerContainer.upgrade(HttpServletRequest, HttpServletResponse, ServerEndpointConfig, pathParamMap) API Expose Spec ServerContainer.upgrade() API Oct 6, 2021
@lachlan-roberts lachlan-roberts removed the Bug For general bugs on Jetty side label Oct 6, 2021
lachlan-roberts added a commit that referenced this issue Oct 7, 2021
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Oct 7, 2021
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Oct 21, 2021
…ammaticUpgrade

Issue #6965 - support programmatic upgrade for javax/jakarta websockets (9.4)
lachlan-roberts added a commit that referenced this issue Oct 21, 2021
…rammaticUpgrade

Issue #6965 - support programmatic upgrade for javax/jakarta websockets (10)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Specification For all industry Specifications (IETF / Servlet / etc)
Projects
None yet
2 participants