Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password Util does not ask for password #9556

Closed
ChrisHuebsch-FLIG opened this issue Mar 31, 2023 · 1 comment · Fixed by #9557
Closed

Password Util does not ask for password #9556

ChrisHuebsch-FLIG opened this issue Mar 31, 2023 · 1 comment · Fixed by #9557
Assignees
@joakime
Labels
Bug For general bugs on Jetty side
Milestone
10.0.x

Comments

@ChrisHuebsch-FLIG
Copy link

Jetty version(s)
10

Java version/vendor (use: java -version)
Adoptiom JRE 11

OS type/version
Windows

Description
Password utility is used to obfuscate passwords, e.g. for keystore.

When running the utility without any parameter

D:\apps_current\jre11\bin\java.exe -cp d:\apps_current\jetty10\lib\jetty-util-10.0.13.jar org.eclipse.jetty.util.security.Password

prints out:

Usage - java org.eclipse.jetty.util.security.Password []
If the password is ?, the user will be prompted for the password

How to reproduce?

Starting the programm with ?, ? or "?" produces always the same result:

OBF:1e2n
MD5:D1457b72C3Fb323a2671125aEf3eAb5d

But I was expecting some input prompt.
@ChrisHuebsch-FLIG ChrisHuebsch-FLIG added the Bug For general bugs on Jetty side label Mar 31, 2023
joakime added a commit that referenced this issue Mar 31, 2023
@joakime
Fixes #9556 - Better prompt for input on Password
f6f58b5 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime self-assigned this Mar 31, 2023
@joakime joakime added this to the 10.0.x milestone Mar 31, 2023
@joakime joakime linked a pull request Mar 31, 2023 that will close this issue
Fixes #9556 - Better prompt for input on Password #9557
Merged
@joakime
Copy link
Contributor

joakime commented Mar 31, 2023

Opened PR #9557 for this

joakime added a commit that referenced this issue Apr 5, 2023
@joakime
Fixes #9556 - Better prompt for input on Password (#9557)
3e42cbf 
* Fixes #9556 - Better prompt for input on Password
* Allow blank username (results in no CRYPT output)
* Error on blank password during input
* Fixing PasswordTest.testCommandLineUsage
* Changes from review

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
10.0.x
Development

Successfully merging a pull request may close this issue.

Fixes #9556 - Better prompt for input on Password jetty/jetty.project
2 participants
@joakime @ChrisHuebsch-FLIG