Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test for #10805 Zero Dynamic Table #11422

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Added test for #10805 Zero Dynamic Table #11422

merged 3 commits into from
Feb 21, 2024

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Feb 20, 2024 •
edited

For #10805

@gregw gregw linked an issue Feb 20, 2024 that may be closed by this pull request
Jetty response with an invalid HTTP2 packet if the client set the hpack table size as 0 #10805
Closed
@gregw gregw mentioned this pull request Feb 20, 2024
Closed
@gregw gregw requested a review from sbordet February 21, 2024 08:08
sbordet
sbordet approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this class a port of what's in 12?
If not, then it'll need to be ported to 12, but in the different test module, and merge it with the existing one.

@gregw
Copy link
Contributor Author

gregw commented Feb 21, 2024

Is this class a port of what's in 12? If not, then it'll need to be ported to 12, but in the different test module, and merge it with the existing one.

It is the same test from 12. I did add a variant of doing both the encoder and decoder at once, but essentially the same.

@gregw gregw merged commit 333714a into jetty-9.4.x Feb 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbordet sbordet sbordet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jetty response with an invalid HTTP2 packet if the client set the hpack table size as 0
2 participants
@gregw @sbordet