Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run http3 tests per default but disable with another option than ci Maven profile #11586

Draft
wants to merge 1 commit into
base: jetty-12.0.x
Choose a base branch
from
Draft

run http3 tests per default but disable with another option than ci Maven profile #11586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...client-transports/src/test/java/org/eclipse/jetty/test/client/transport/AbstractTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public class AbstractTest
public static Collection<Transport> transports()
{
EnumSet<Transport> transports = EnumSet.allOf(Transport.class);
if ("ci".equals(System.getProperty("env")))
if (Boolean.getBoolean("skip.http3.tests"))
transports.remove(Transport.H3);
return transports;
}
Expand Down
2 changes: 1 addition & 1 deletion ...t-transports/src/test/java/org/eclipse/jetty/ee10/test/client/transport/AbstractTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public class AbstractTest
public static Collection<Transport> transports()
{
EnumSet<Transport> transports = EnumSet.allOf(Transport.class);
if ("ci".equals(System.getProperty("env")))
if (Boolean.getBoolean("skip.http3.tests"))
transports.remove(Transport.H3);
return transports;
}
Expand Down
2 changes: 1 addition & 1 deletion ...nt-transports/src/test/java/org/eclipse/jetty/ee9/test/client/transport/AbstractTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public class AbstractTest
public static Collection<Transport> transports()
{
EnumSet<Transport> transports = EnumSet.allOf(Transport.class);
if ("ci".equals(System.getProperty("env")))
if (Boolean.getBoolean("skip.http3.tests"))
transports.remove(Transport.H3);
return transports;
}
Expand Down
3 changes: 3 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,7 @@
<project.build.outputTimestamp>2023-06-05T23:12:49Z</project.build.outputTimestamp>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<settingsPath>src/it/settings.xml</settingsPath>
<skip.http3.tests>false</skip.http3.tests>
<slf4j.version>2.0.9</slf4j.version>
<spifly.version>1.3.6</spifly.version>
<spotbugs.maven.plugin.version>4.8.3.1</spotbugs.maven.plugin.version>
Expand Down Expand Up @@ -1495,6 +1496,7 @@
<systemPropertyVariables>
<jetty.unixdomain.dir>${jetty.unixdomain.dir}</jetty.unixdomain.dir>
<jetty.testtracker.log>${jetty.testtracker.log}</jetty.testtracker.log>
<skip.http3.tests></skip.http3.tests>
</systemPropertyVariables>
<!-- The LC_ALL env variable must have some UTF variant otherwise creating and/or reading files with non-ascii names doesn't work -->
<environmentVariables>
Expand Down Expand Up @@ -2266,6 +2268,7 @@
<home.start.timeout>120</home.start.timeout>
<!-- need a good default value if running this profile locally with empty repo -->
<maven.repo.uri>https://repo.maven.apache.org/maven2/</maven.repo.uri>
<skip.http3.tests>false</skip.http3.tests>
<!-- Defines a SpotBugs effort. Use "Max" to maximize the scan depth -->
<spotbugs.effort>Default</spotbugs.effort>
<spotbugs.failOnError>false</spotbugs.failOnError>
Expand Down