Issue #1797 - JEP 238 - Multi-Release JAR files break bytecode scanning. #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made MultiReleaseJarFile closeable and using try-with-resources in AnnotationParser to avoid leaking file descriptors. Made few code simplifications. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
joakime
requested changes
Nov 8, 2017
| { | ||
| parseJarEntry(handlers, jarResource, e, resolver); | ||
| } | ||
| catch (Exception ex) |
There was a problem hiding this comment.
Do we really want to catch any Exception?
What if the jar file itself has entries that can be iterated, but not read?
Wouldn't that result in a MultiException containing an entry for each and every entry?
There was a problem hiding this comment.
Lets deal with this if it becomes a problem. Too complicated to work out now.
| me.add(new RuntimeException("Error scanning entry " + e.getName() + " from jar " + jarResource, ex)); | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
An exception opening the JarFile isn't caught / added to the MultiException. (eg: a bad jar file)
There was a problem hiding this comment.
On second thought, the method itself will pass a JarFile error out properly, no need for the MultiException route.
joakime
approved these changes
Nov 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made MultiReleaseJarFile closeable and using try-with-resources in
AnnotationParser to avoid leaking file descriptors.
Made few code simplifications.
Signed-off-by: Simone Bordet simone.bordet@gmail.com