Jetty 9.4.x 3550 queued thread pool stalled #3586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously if there were no idle threads, QueuedThreadPool.execute() would just queue the job and not start a new thread to run it Signed-off-by: lachan-roberts <lachlan@webtide.com>
gregw
added
Bug
joakime
reviewed
Apr 24, 2019
| QueuedThreadPool pool = new QueuedThreadPool(4, 3); | ||
|
|
||
| String dump = pool.dump(); | ||
| // TODO use hamcrest 2.0 regex matcher |
There was a problem hiding this comment.
I need to do a refresh of maven-test-helper for Jetty 9.4.x anyway.
In the meantime you can use the maven-test-helper regex version ...
import static org.eclipse.jetty.websocket.common.test.MoreMatchers.regex;
assertThat(endpoint.capture.pollMessages(), regex("^onBinary\\(.*InputStream.*"));There was a problem hiding this comment.
never mind, that's a websocket specific matcher.
i'll upgrade maven-test-helper today. (and even include the new Net helper for junit 5. 879e161)
joakime
approved these changes
Apr 24, 2019
joakime
reviewed
Apr 24, 2019
| @@ -603,7 +604,7 @@ public void dump(Appendable out, String indent) throws IOException | |||
| String knownMethod = ""; | |||
| for (StackTraceElement t : trace) | |||
| { | |||
| if ("idleJobPoll".equals(t.getMethodName()) && t.getClassName().endsWith("QueuedThreadPool")) | |||
| if ("idleJobPoll".equals(t.getMethodName()) && t.getClassName().endsWith("QueuedThreadPool$Runner")) | |||
There was a problem hiding this comment.
can this be ...
if ("idleJobPoll".equals(t.getMethodName()) && t.getClassName().equals(Runner.class.getName()))instead? To avoid static name of class, if someone refactors that class (again), which broken this before.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3550 by ensure that a new thread is always started when: