Issue #3840 Static resource byte-range support performance #3910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
+ Reverting toFile().getInputStream() on PathResource + Adding RangeWriter concept for managing open resource across multiple range writes + RangeWriter implementation delegates to HttpContent behaviors Lookup is : - Direct Buffer - Indirect Buffer - ReadableByteChannel (as SeekableByteChannel) - InputStream + Adding unit tests for all RangeWriter implementation to ensure that they behave the same way everywhere. + Making ResourceService use new RangeWriter implementation + Existing DefaultServletRangeTest still works as-is Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
|
The implementation and test case are complete. I'm working on collecting some numbers from tests on 9.2.28.v20190418 (which still had FileResource as default), 9.4.19, and this branch. |
+ SPARSE hint only applies to real os file systems or default file systems, not for all file systems. Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
sbordet
reviewed
Jul 26, 2019
jetty-server/src/main/java/org/eclipse/jetty/server/resource/InputStreamRangeWriter.java
Outdated
Show resolved
Hide resolved
gregw
requested changes
Jul 26, 2019
jetty-util/src/main/java/org/eclipse/jetty/util/resource/PathResource.java
Show resolved
Hide resolved
jetty-util/src/test/java/org/eclipse/jetty/util/resource/PathResourceTest.java
Show resolved
Hide resolved
jetty-server/src/main/java/org/eclipse/jetty/server/ResourceService.java
Outdated
Show resolved
Hide resolved
+ break out if progress isn't made, loop if not enough progress is made Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
+ Construction of PathResource now tests if path belongs to the Default FileSystem or not. This important info for later actions against the PathResource that would need to know the File object for the Path object. Non-Default FileSystem == null Default FileSystem == Path.toFile() Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
gregw
reviewed
Jul 30, 2019
jetty-util/src/main/java/org/eclipse/jetty/util/resource/PathResource.java
Show resolved
Hide resolved
gregw
reviewed
Jul 30, 2019
jetty-server/src/main/java/org/eclipse/jetty/server/resource/InputStreamRangeWriter.java
Show resolved
Hide resolved
gregw
approved these changes
Jul 30, 2019
+ Reset progress on any positive skip value + Throw IOException(EOF) for any negative skip value Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
+ Using techniques from SeekableByteChannelRangeWriter with variant for -1 count parameter Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
+ Removing unnecessary variables (per PR review) Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
|
@gregw you'll want to review the extra 3 commits since your approval. |
gregw
requested changes
Jul 30, 2019
jetty-util/src/main/java/org/eclipse/jetty/util/resource/PathResource.java
Show resolved
Hide resolved
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lookup is :
Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com