Issue #4433 - Implement ServletContext.addJspFile #4463
Conversation
Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel
added
the
Specification
|
|
||
| root.addBean(new MySCIStarter(root.getServletContext(), new JSPAddingSCI()), true); | ||
| _server.start(); | ||
| } |
There was a problem hiding this comment.
All other tests in this class have code that actually make a HTTP request to test the functionality.
This new test only adds the dynamic JSP but does not test that making a HTTP request to it works.
Is that intended?
There was a problem hiding this comment.
Also, should we not have 3 tests for this functionality? No mapping, partial mapping, existing mapping?
There was a problem hiding this comment.
I can't add a test for a jsp file because jetty-servlet cannot depend on apache-jsp module. I've added an assertion that tests that the mapped jsp servlet is the one matched by the ServletHandler for the given path, that's as much as we can do.
I also added tests for an existing full mapping and an existing preliminary mapping.
There was a problem hiding this comment.
Can we add a jspFile via this API in the test-spec webapp as an integration test?
There was a problem hiding this comment.
That was already part of the initial commit: the test-spec-webapp calls addJsp via a ServletContainerInitiaizer. See https://github.com/eclipse/jetty.project/blob/jetty-10.0.x-4433-addJspFile/tests/test-webapps/test-servlet-spec/test-container-initializer/src/main/java/com/acme/initializer/FooInitializer.java#L108 and https://github.com/eclipse/jetty.project/blob/jetty-10.0.x-4433-addJspFile/tests/test-webapps/test-servlet-spec/test-spec-webapp/src/main/java/com/acme/test/AnnotationTest.java#L255
There was a problem hiding this comment.
great! can we then check that the test-distribution will see any fail for this?
joakime
changed the title
Signed-off-by: Jan Bartel <janb@webtide.com>
|
|
||
| root.addBean(new MySCIStarter(root.getServletContext(), new JSPAddingSCI()), true); | ||
| _server.start(); | ||
| } |
There was a problem hiding this comment.
Can we add a jspFile via this API in the test-spec webapp as an integration test?
Signed-off-by: Jan Bartel <janb@webtide.com>
Implement servlet 4.0 ServletContext.addJspFile.
Closes #4433