Issue #5069 - Fixing assumeConnectTimeout test condition #5070
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
sbordet
requested changes
Jul 21, 2020
| @@ -520,7 +521,7 @@ private void assumeConnectTimeout(String host, int port, int connectTimeout) | |||
| catch (Throwable x) | |||
| { | |||
| // Abort if any other exception happens. | |||
| fail(x); | |||
| throw new TestAbortedException("Not able to validate connect timeout conditions", x); | |||
There was a problem hiding this comment.
Please use Assumptions instead of throwing directly - it's not clear if you want the test to fail or what.
There was a problem hiding this comment.
The test will abort, not fail.
Using Assumptions makes the test either continue or abort, never fail.
Abort marks the test as ignored.
Using TestAbortedException preserves the stacktrace, which is then reported when a test is aborted. (this information is even present in your IDE)
Using Assumptions loses this stacktrace.
There was a problem hiding this comment.
We do a similar thing in the AllowSymLinkAliasCheckerTest.
sbordet
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com