Fixes #5152 - HttpClient should handle unsolicited responses. #5166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now closing the connection if an unsolicited response is detected, no matter what response status code, or whether it has a Connection: close header, or whether it's just random bytes from the server, and also no matter whether the client read -1. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
|
@gregw CI is green at build 3, and 4 is building right now... where do you see the failure? |
|
@sbordet I just see a red cross on this page. I didn't follow the Details link.... which if I do takes me to 1 test failure: https://jenkins.webtide.net/blue/organizations/jenkins/jetty.project/detail/PR-5166/4/tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now closing the connection if an unsolicited response is detected,
no matter what response status code, or whether it has a
Connection: close header, or whether it's just random bytes from
the server, and also no matter whether the client read -1.
Signed-off-by: Simone Bordet simone.bordet@gmail.com