Issue #5901 Update to javax.servlet.api 4.0.6. #5918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings in a change to the javax.servlet.api module-info to open the javax.servlet.resources package to all modules, so that the dtds and xsds can be retrieved as resources, either from the context Classloader.getResource, or from the ServletContext.class.getResource. Signed-off-by: Jan Bartel <janb@webtide.com>
sbordet
approved these changes
Jan 26, 2021
janbartel
deleted the
jetty-10.0.x-5901-javax.servlet.resources-must-be-opened
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to jetty toolchain servlet-api jar version 4.0.6, which contains a change to it's module-info to
openthejavax.servlet.resourcespackage to all modules.This change was necessary because the org.mortbay apache-jsp jar (which is an automatic module) uses ServletContext.class.getResource(String) in order to obtain the servlet dtds and xsds, and that method needs the javax.servlet.resources package to be
opened in order for them to be visible.