UriCompliance mode improvements #6132 #6137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbordet
requested changes
Apr 6, 2021
jetty-http/src/main/java/org/eclipse/jetty/http/UriCompliance.java
Outdated
Show resolved
Hide resolved
jetty-server/src/test/java/org/eclipse/jetty/server/RequestTest.java
Outdated
Show resolved
Hide resolved
jetty-server/src/test/java/org/eclipse/jetty/server/RequestTest.java
Outdated
Show resolved
Hide resolved
Updates from review
joakime
requested changes
Apr 6, 2021
jetty-http/src/main/java/org/eclipse/jetty/http/UriCompliance.java
Outdated
Show resolved
Hide resolved
jetty-http/src/main/java/org/eclipse/jetty/http/UriCompliance.java
Outdated
Show resolved
Hide resolved
Updates from review
joakime
requested changes
Apr 6, 2021
jetty-http/src/main/java/org/eclipse/jetty/http/UriCompliance.java
Outdated
Show resolved
Hide resolved
jetty-http/src/main/java/org/eclipse/jetty/http/UriCompliance.java
Outdated
Show resolved
Hide resolved
jetty-http/src/main/java/org/eclipse/jetty/http/UriCompliance.java
Outdated
Show resolved
Hide resolved
sbordet
requested changes
Apr 6, 2021
jetty-server/src/main/java/org/eclipse/jetty/server/Request.java
Outdated
Show resolved
Hide resolved
|
@joakime with regards to the |
Updates from review
sbordet
approved these changes
Apr 7, 2021
|
@joakime nudge |
joakime
approved these changes
Apr 7, 2021
|
@joakime something strange is happening.... you've approved the changes, but I'm still seeing a red cross and requested changes from you??? What does this issue look like to you? |
|
Oh... as soon as I commented it went green! strange!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6132
This PR reverts the default behaviour to allows URIs that contain
%2F. I'm only 80% convinced of this and we need to consider really carefully before changing the default again.The PR also contains a non-string based way to create custom
UriComplianceinstances.It also introduces a new
Violationthat will allow ambiguous Uri to be passed to the application without extra normalisation.