Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #6302 - Treat empty path segments as ambiguous. #6304
Issue #6302 - Treat empty path segments as ambiguous. #6304
Changes from 2 commits
36332ab
c30875e
3206dab
3aec963
0cae7bf
2649182
2792217
3dd5460
93eaffd
918f377
339e245
26d1646
ceccab9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add other combinations?
//ambiguous/initial
/ambiguous//middle
/double//ambiguous//
//triple//ambiguous//
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this would be the right place for these extra tests. This is just testing how the compliance modes handle and empty segment.
What combinations cause an empty segment is tested by
HttpUriTest
. We already cover these cases, but I have also added these ones exactly to be sure.