New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compliance modes documentation #6312
Conversation
This is a DRAFT! Signed-off-by: Greg Wilkins <gregw@webtide.com>
This is a DRAFT! Signed-off-by: Greg Wilkins <gregw@webtide.com>
@sbordet I have worked on the HttpCompliance javadoc and the corresponding documentation, along the lines we discussed. |
This is a DRAFT! Signed-off-by: Greg Wilkins <gregw@webtide.com>
@sbordet nudge |
Signed-off-by: Greg Wilkins <gregw@webtide.com>
@sbordet This is building now. |
Reworked and expanded. Also added CookieCompliance.from(String) that was missing. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@gregw please review/comment on my changes. |
@@ -20,6 +20,7 @@ Protocols:: | |||
* xref:og-protocols-http[HTTP/1.1 Support] | |||
* xref:og-protocols-http2[HTTP/2 Support] | |||
* xref:og-protocols-websocket[WebSocket Support] | |||
* xref:og-server-compliance[RFC Compliance Modes] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbordet I don't think you are fully pushed? I can't see where og-server-compliance is defined?
Also I think the section should just be "Compliance Modes" rather than RFC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gregw I removed it as now it's prominent in the programming guide, under "Server Compliance Modes".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbordet I thought the compliance section was a bit burried and hard to find. So I've given it its own section under the server module. I think the text of that whole section could do with some spruiking, but I don't mind the structure and general content.
Removed link to Server compliance from the operations guide, as it's now linked from the programming guide. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Greg Wilkins <gregw@webtide.com>
This may not be perfect, but I'd like to get it in the next release |
documentation/jetty-documentation/src/main/asciidoc/operations-guide/modules/module-server.adoc
Outdated
Show resolved
Hide resolved
...entation/src/main/asciidoc/programming-guide/server/compliance/server-compliance-cookie.adoc
Show resolved
Hide resolved
documentation/jetty-documentation/src/main/asciidoc/operations-guide/modules/module-server.adoc
Show resolved
Hide resolved
documentation/jetty-documentation/src/main/asciidoc/operations-guide/modules/module-server.adoc
Show resolved
Hide resolved
documentation/jetty-documentation/src/main/asciidoc/operations-guide/modules/module-server.adoc
Show resolved
Hide resolved
...umentation/src/main/asciidoc/programming-guide/server/compliance/server-compliance-http.adoc
Outdated
Show resolved
Hide resolved
documentation/jetty-documentation/src/main/asciidoc/operations-guide/modules/module-server.adoc
Show resolved
Hide resolved
Signed-off-by: Greg Wilkins <gregw@webtide.com>
Compliance doco