Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compliance modes documentation #6312

Merged
merged 10 commits into from Jun 24, 2021
Merged

Conversation

gregw
Copy link
Contributor

@gregw gregw commented May 21, 2021

Compliance doco

This is a DRAFT!

Signed-off-by: Greg Wilkins <gregw@webtide.com>
This is a DRAFT!

Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw
Copy link
Contributor Author

gregw commented May 25, 2021

@sbordet I have worked on the HttpCompliance javadoc and the corresponding documentation, along the lines we discussed.
If you think it is OK, I'll do the same for Cookie and URI compliance.

This is a DRAFT!

Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw gregw marked this pull request as ready for review June 8, 2021 23:19
@gregw
Copy link
Contributor Author

gregw commented Jun 12, 2021

@sbordet nudge

@gregw
Copy link
Contributor Author

gregw commented Jun 15, 2021

@sbordet This is building now.

Reworked and expanded.
Also added CookieCompliance.from(String) that was missing.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet
Copy link
Contributor

sbordet commented Jun 17, 2021

@gregw please review/comment on my changes.

@@ -20,6 +20,7 @@ Protocols::
* xref:og-protocols-http[HTTP/1.1 Support]
* xref:og-protocols-http2[HTTP/2 Support]
* xref:og-protocols-websocket[WebSocket Support]
* xref:og-server-compliance[RFC Compliance Modes]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbordet I don't think you are fully pushed? I can't see where og-server-compliance is defined?
Also I think the section should just be "Compliance Modes" rather than RFC

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gregw I removed it as now it's prominent in the programming guide, under "Server Compliance Modes".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbordet I thought the compliance section was a bit burried and hard to find. So I've given it its own section under the server module. I think the text of that whole section could do with some spruiking, but I don't mind the structure and general content.

sbordet and others added 2 commits June 18, 2021 08:54
Removed link to Server compliance from the operations guide,
as it's now linked from the programming guide.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw gregw added this to In progress in Jetty 10.0.6/11.0.6 FROZEN via automation Jun 21, 2021
@gregw gregw requested review from janbartel and removed request for sbordet June 21, 2021 23:49
@gregw
Copy link
Contributor Author

gregw commented Jun 21, 2021

This may not be perfect, but I'd like to get it in the next release

Jetty 10.0.6/11.0.6 FROZEN automation moved this from In progress to Review in progress Jun 22, 2021
Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw gregw requested review from janbartel and sbordet June 24, 2021 04:50
Jetty 10.0.6/11.0.6 FROZEN automation moved this from Review in progress to Reviewer approved Jun 24, 2021
@gregw gregw merged commit 4673846 into jetty-10.0.x Jun 24, 2021
Jetty 10.0.6/11.0.6 FROZEN automation moved this from Reviewer approved to Done Jun 24, 2021
@joakime joakime deleted the jetty-10.0.x-compliance-doco branch July 12, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants