Issue #6473 - Improve alias checking in PathResource. #6477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gregw see |
|
@sbordet added test |
gregw
previously approved these changes
Jun 28, 2021
jetty-server/src/main/java/org/eclipse/jetty/server/handler/ContextHandler.java
Show resolved
Hide resolved
jetty-util/src/main/java/org/eclipse/jetty/util/resource/PathResource.java
Show resolved
Hide resolved
gregw
previously approved these changes
Jun 28, 2021
* Reverted %-escape handling for URI query parts. * Performing canonicalization in ServletContext.getResource(), and improving alias checking in ContextHandler.getResource(). * Performing canonicalization checks in Resource.addPath() to avoid navigation above of the root. * Test added and fixed. * Various cleanups. * Improved javadoc and comments Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
gregw
force-pushed
the
jetty-9.4.x-6473-improve-alias-checking
branch
from
5f61a00
to
2e75feb
Compare
gregw
previously approved these changes
Jun 29, 2021
restored removed method as deprecated
restored removed method as deprecated
gregw
previously approved these changes
Jun 29, 2021
lachlan-roberts
previously approved these changes
Jun 29, 2021
use UriCompliance.Violation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #6473
and improving alias checking in ContextHandler.getResource().
navigation above of the root.
Signed-off-by: Simone Bordet simone.bordet@gmail.com