Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #6470 - prevent EOF being released back into pool in MessageInputStream #6486

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Issue #6470 - prevent EOF being released back into pool in MessageInputStream #6486

merged 1 commit into from
Jun 30, 2021

Conversation

lachlan-roberts
Copy link
Contributor

@lachlan-roberts lachlan-roberts commented Jun 30, 2021 •
edited by gregw
Loading

Issue #6470

Prevent the static readOnly buffer EOF from being released back into the ByteBufferPool.

Alternative to #6485

@lachlan-roberts
Issue #6470 - prevent EOF being released back into pool
039a539 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
gregw approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks better!

@gregw gregw mentioned this pull request Jun 30, 2021
Closed
@gregw gregw added this to In progress in Jetty 9.4.43 FROZEN via automation Jun 30, 2021
@lachlan-roberts lachlan-roberts merged commit 40535f1 into jetty-9.4.x Jun 30, 2021
Jetty 9.4.43 FROZEN automation moved this from In progress to Done Jun 30, 2021
@lachlan-roberts lachlan-roberts deleted the jetty-9.4.x-6470-MessageInputStreamEOF branch June 30, 2021 09:24
@lachlan-roberts lachlan-roberts mentioned this pull request Jun 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Jetty 9.4.43 FROZEN
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lachlan-roberts @gregw