Disable ipv6 test for #6624 #6625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temp disable of test that is breaking the build.
gregw
requested review from
sbordet,
joakime,
lachlan-roberts and
olamy
and removed request for
joakime and
sbordet
|
CI failure is unrelated flakey test. See #6626 |
olamy
reviewed
Aug 17, 2021
| @@ -1014,6 +1013,7 @@ public void testForcedNonDomainSNI() throws Exception | |||
| .send(); | |||
| assertEquals(HttpStatus.OK_200, response2.getStatus()); | |||
|
|
|||
| /* TODO Fix. See #6624 | |||
There was a problem hiding this comment.
what about marking the test method with @DisabledOnJre({JRE.JAVA_17})
easier to search for common annotation @Disabled*
There was a problem hiding this comment.
Because the test is parameterized and tests other stuff. So the test is not disabled, just the IPv6 part of it is.
There was a problem hiding this comment.
The problem is its hard to keep track of TODOs because we have so many of them in the code. So it might just get lost and never be fixed, maybe if you at least commented in the issue as a reminder so it is not forgotten.
There was a problem hiding this comment.
Will do. This PR does not close the issue, so the issue will remain open.
olamy
requested changes
Aug 17, 2021
lachlan-roberts
approved these changes
Aug 17, 2021
olamy
approved these changes
Aug 17, 2021
gregw
added a commit
that referenced
this pull request
Aug 17, 2021
gregw
added a commit
that referenced
this pull request
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temp disable of ipv6 test for #6624, that is breaking the build.