Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #6327 Remove/re-enable disabled ShutdownMonitorTest tests #6630

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Issue #6327 Remove/re-enable disabled ShutdownMonitorTest tests #6630

merged 1 commit into from
Sep 2, 2021

Conversation

janbartel
Copy link
Contributor

Part of the disabled tests review in #6327

  • testStartStopSamePortDifferentKey() - removed this test, as you cannot know that the port you previously used will still be available to rerun the test
  • testStartStopDifferentPortDifferentKey() - re-enabled this test, as I can't see how it would be problematic

@janbartel
Issue #6327 Remove/re-enable disabled ShutdownMonitorTest tests
a42582e 
Signed-off-by: Jan Bartel <janb@webtide.com>
@janbartel janbartel self-assigned this Aug 17, 2021
@janbartel janbartel added this to In progress in Jetty 10.0.7/11.0.7 FROZEN via automation Aug 17, 2021
Jetty 10.0.7/11.0.7 FROZEN automation moved this from In progress to Reviewer approved Aug 22, 2021
@janbartel janbartel merged commit db1c655 into jetty-10.0.x Sep 2, 2021
Jetty 10.0.7/11.0.7 FROZEN automation moved this from Reviewer approved to Done Sep 2, 2021
@janbartel janbartel deleted the jetty-10.0.x-6327-shutdownmonitortest branch September 2, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olamy olamy olamy approved these changes

@joakime joakime Awaiting requested review from joakime

Assignees

@janbartel janbartel

Labels
None yet
Projects
No open projects
Jetty 10.0.7/11.0.7 FROZEN
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@janbartel @olamy