Issue #6974 - improvements & fixes to ByteBufferPool implementations #7017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…g of bucket size. Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lorban
requested changes
Oct 20, 2021
jetty-io/src/main/java/org/eclipse/jetty/io/ArrayByteBufferPool.java
Outdated
Show resolved
Hide resolved
jetty-io/src/main/java/org/eclipse/jetty/io/ByteBufferPool.java
Outdated
Show resolved
Hide resolved
jetty-io/src/main/java/org/eclipse/jetty/io/MappedByteBufferPool.java
Outdated
Show resolved
Hide resolved
jetty-io/src/main/java/org/eclipse/jetty/io/ArrayByteBufferPool.java
Outdated
Show resolved
Hide resolved
jetty-io/src/main/java/org/eclipse/jetty/io/AbstractByteBufferPool.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
reviewed
Oct 21, 2021
lorban
previously approved these changes
Oct 21, 2021
jetty-io/src/main/java/org/eclipse/jetty/io/ArrayByteBufferPool.java
Outdated
Show resolved
Hide resolved
Jetty 9.4.45 - FROZEN
automation
moved this from Review in progress
to Reviewer approved
Oct 21, 2021
sbordet
requested changes
Oct 21, 2021
jetty-io/src/main/java/org/eclipse/jetty/io/LogArrayByteBufferPool.java
Outdated
Show resolved
Hide resolved
jetty-io/src/main/java/org/eclipse/jetty/io/ArrayByteBufferPool.java
Outdated
Show resolved
Hide resolved
jetty-io/src/main/java/org/eclipse/jetty/io/LogArrayByteBufferPool.java
Outdated
Show resolved
Hide resolved
jetty-io/src/main/java/org/eclipse/jetty/io/ByteBufferPool.java
Outdated
Show resolved
Hide resolved
Jetty 9.4.45 - FROZEN
automation
moved this from Reviewer approved
to Review in progress
Oct 21, 2021
|
@gregw @lachlan-roberts overall I feel that these changes are too much for 9.4.x. |
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
|
@sbordet @lachlan-roberts let's hangout tonight(tomorrow morning) |
|
... but note that whilst I don't like changes in 9.4, I also don't like the unlimited memory commitment that we currently allow with the default pool with no easy way to change it. |
Latest review with @lachlan-roberts. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Jetty 9.4.45 - FROZEN
automation
moved this from Review in progress
to Reviewer approved
Nov 12, 2021
sbordet
previously approved these changes
Nov 12, 2021
Latest review with @lachlan-roberts. Fixed typo. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Jetty 9.4.45 - FROZEN
automation
moved this from Reviewer approved
to Review in progress
Nov 12, 2021
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
requested changes
Nov 16, 2021
jetty-io/src/main/java/org/eclipse/jetty/io/AbstractByteBufferPool.java
Outdated
Show resolved
Hide resolved
…74-WebSocketBufferPool
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
approved these changes
Nov 23, 2021
Jetty 9.4.45 - FROZEN
automation
moved this from Review in progress
to Reviewer approved
Nov 23, 2021
lachlan-roberts
added a commit
that referenced
this pull request
Nov 24, 2021
…7017) - WebSocket should user server ByteBufferPool if possible - fix various bugs ByteBufferPool implementations - add heuristic for maxHeapMemory and maxDirectMemory - Add dump for ByteBufferPools - add LogArrayByteBufferPool that does exponential scaling of bucket size. - ByteBufferPools should default to use maxMemory heuristic - Add module jetty-bytebufferpool-logarithmic Signed-off-by: Lachlan Roberts <lachlan@webtide.com> Co-authored-by: Simone Bordet <simone.bordet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #6974 - improvements to ByteBufferPool implementations
ByteBufferPool Changes
ArrayByteBufferPoolandMappedByteBufferPoolwith non zero settings formaxHeapMemoryandmaxDirectMemory.maxHeapMemoryandmaxDirectMemorymean that a default is calculated based on the total max memory of the JVM.ArrayByteBufferPoolandMappedByteBufferPoolextensible to change the bucket scaling.LogArrayByteBufferPoolwhich doubles the size of each consecutive bucket instead of scaling linearly.Dumpablefor the ByteBufferPool implementations.WebSocket Changes
WebSocketUpgradeFilteralways waits until it is started before it gets theNativeWebSocketConfigurationso it can be created when theByteBufferPoolis ready.ByteBufferPoolinstead of creating its ownMappedByteBufferPoolevery time.