Fix #7929 requestlog format string commented default #7931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Padraic Renaghan <padraic@renaghan.com>
joakime
moved this from In progress
to Review in progress
in Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶
Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶
automation
moved this from Review in progress
to Reviewer approved
Apr 28, 2022
lachlan-roberts
approved these changes
Apr 28, 2022
|
Thanks for the PR. |
Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶
automation
moved this from Reviewer approved
to Done
Apr 28, 2022
|
@lachlan-roberts don't forget to merge forward (or cherry-pick) to 12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Padraic Renaghan padraic@renaghan.com
Change the commented default
jetty.requestlog.formatStringinrequestlog.inito match what theCustomRequestLogcode actually does.Also the current comment mentions
%Bwhich is not listed as valid in the documentation - which confused me for a while.And the
%ais missing the format parameter used in the code.This aligns the comment with the default value, which seems to be the pattern of the values in module default
.inifiles. Also aligns said comment with format specifiers listed in the online documentation. All of which goes to avoid confusion and questions by folks configuring Jetty requestlog module.