Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude log4j-core to avoid problem with m-enforcer-p see https://issues.apache.org/jira/browse/LOG4J2-3241 #8094

Conversation

olamy
Copy link
Member

@olamy olamy commented Jun 1, 2022

Signed-off-by: Olivier Lamy oliver.lamy@gmail.com

to avoid issues such

Downloading from public-jboss: https://repository.jboss.org/nexus/content/groups/public-jboss/org/apache/logging/log4j/log4j-core-java9/2.13.3/log4j-core-java9-2.13.3.pom
[WARNING] Rule 6: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:
Could not build dependency tree Could not collect dependencies: org.eclipse.jetty:infinispan-common:jar:11.0.10-SNAPSHOT ()

@olamy olamy added the Build label Jun 1, 2022
Copy link
Contributor

@lachlan-roberts lachlan-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olamy This change alone did not fix the build failure for me.
I had to add this same exclusion to all the following poms before I saw a green build:

infinispan-common
infinispan-remote
infinispan-remote-query
test-infinispan-sessions

Java Version: 17.0.2
Maven Version: 3.8.5

@olamy
Copy link
Member Author

olamy commented Jun 1, 2022

@olamy This change alone did not fix the build failure for me. I had to add this same exclusion to all the following poms before I saw a green build:

infinispan-common
infinispan-remote
infinispan-remote-query
test-infinispan-sessions

Java Version: 17.0.2 Maven Version: 3.8.5

oh good point.
I have a better idea. Thanks to be my guinea pig for testing this :P

olamy added 2 commits June 2, 2022 11:37
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Copy link
Contributor

@lachlan-roberts lachlan-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks.

@olamy olamy merged commit d12ee70 into jetty-10.0.x Jun 2, 2022
@olamy olamy deleted the jetty-10.0.x-avoid-enforcer-problem-with-wrong-log4j-dependencies branch June 2, 2022 08:24
olamy added a commit that referenced this pull request Jun 6, 2022
…ues.apache.org/jira/browse/LOG4J2-3241 (#8094)

* exclude log4j-core to avoid problem with m-enforcer-p see https://issues.apache.org/jira/browse/LOG4J2-3241

Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
olamy added a commit that referenced this pull request Jun 6, 2022
…ues.apache.org/jira/browse/LOG4J2-3241 (#8094) (#8113)

* exclude log4j-core to avoid problem with m-enforcer-p see https://issues.apache.org/jira/browse/LOG4J2-3241

Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants