Cherry-pick of Improvements to PathSpec for Jetty 10.0.x #8136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From commit: 5b4d1dd Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime
added
Enhancement
Sponsored
joakime
moved this from In progress
to Reviewer approved
in Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶
joakime
moved this from Reviewer approved
to Review in progress
in Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
|
@joakime this looks to have broken a lot of tests... which don't look like flakes ? |
|
Yes, some things I appear to have missed. |
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
sbordet
previously approved these changes
Jun 8, 2022
Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶
automation
moved this from Review in progress
to Reviewer approved
Jun 8, 2022
|
@joakime is this still a draft? |
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶
automation
moved this from Reviewer approved
to Review in progress
Jun 8, 2022
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶
automation
moved this from Review in progress
to Reviewer approved
Jun 8, 2022
sbordet
approved these changes
Jun 8, 2022
joakime
added a commit
that referenced
this pull request
Oct 6, 2022
* Cherry-pick of Improvements to PathSpec. * From commit: 5b4d1dd * Fixing ConstraintSecurityHandler usage of PathMappings * Fixing bad INCLUDE logic from cherry-pick in ServletHandler.doScope() * Cleanup of non ServletPathSpec behaviors in ServletPathMapping class * Skip optional group name/info lookup if regex fails. * Prevent NPE on static servletPathMappings * Update WebSocketMappings to use new PathMappings.getMatched(String) Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From PR: #7947
From commit: 5b4d1dd
Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com