Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable H3 tests by default with a system property to explicitly enable them #8150

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

lorban
Copy link
Contributor

@lorban lorban commented Jun 9, 2022

As it says on the tin.

…ly enable them

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban requested review from olamy and gregw June 9, 2022 10:51
@lorban lorban self-assigned this Jun 9, 2022
@lorban lorban linked an issue Jun 9, 2022 that may be closed by this pull request
@lorban lorban changed the title #8149 disable H3 tests by default with a system property to explicitly enable them Disable H3 tests by default with a system property to explicitly enable them Jun 9, 2022
@olamy
Copy link
Member

olamy commented Jun 9, 2022

we might need something to enable it via command line
in pom of test-http-client-transport, something such:

  <properties>
    <bundle-symbolic-name>${project.groupId}.client.http</bundle-symbolic-name>
    <h3.test.enabled>false</h3.test.enabled>
  </properties>
...
  <build>
    <pluginManagement>
      <plugins>
        <plugin>
          <groupId>org.apache.maven.plugins</groupId>
          <artifactId>maven-surefire-plugin</artifactId>
          <configuration>
            <systemPropertyVariables>
              <org.eclipse.jetty.http.client.TransportProvider.H3.enable>${h3.test.enabled}</org.eclipse.jetty.http.client.TransportProvider.H3.enable>
            </systemPropertyVariables>
          </configuration>
        </plugin>
      </plugins>
    </pluginManagement>
....

So we can enable this in CI if needed with adding: -Dh3.test.enabled=true
let me know and I can add it (but my tomorrow)

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban
Copy link
Contributor Author

lorban commented Jun 9, 2022

@olamy thanks, added it myself.

@sbordet sbordet merged commit 1f902f6 into jetty-10.0.x Jun 16, 2022
@sbordet sbordet deleted the jetty-10.0.x-8149-disable-h3-tests branch June 16, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable H3 tests by default
4 participants