Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add module configuration for demo handler #8490

Merged
merged 3 commits into from
Sep 2, 2022
Merged

add module configuration for demo handler #8490

merged 3 commits into from
Sep 2, 2022

Conversation

olamy
Copy link
Member

@olamy olamy commented Aug 29, 2022

Signed-off-by: Olivier Lamy oliver.lamy@gmail.com

@olamy
add module configuration for demo handler
9a5526c 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy
Copy link
Member Author

olamy commented Aug 29, 2022 •
edited

finally maybe a name such demo-core-handler would be better. then we could have more demo-core-xxx
@sbordet @joakime @gregw ?

@olamy olamy changed the title add module configuration for demo handler add module configuration for demo core handler Aug 31, 2022
@sbordet
Copy link
Contributor

sbordet commented Aug 31, 2022

I prefer just demo-handler or core-demo-handler since the environment is always first.

@olamy
remove commented code
9996641 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy olamy changed the title add module configuration for demo core handler add module configuration for demo handler Sep 2, 2022
@olamy
some changes fron review
b73b030 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy olamy requested a review from sbordet September 2, 2022 04:50
@olamy olamy merged commit d11b5e0 into jetty-12.0.x Sep 2, 2022
@olamy olamy deleted the jetty-12.0.x-fix-demo-handler branch September 2, 2022 07:46
@olamy olamy mentioned this pull request Dec 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbordet sbordet sbordet approved these changes

@gregw gregw Awaiting requested review from gregw

@joakime joakime Awaiting requested review from joakime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olamy @sbordet