Serialize onCompleteFailure for #9059 #9062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, exiting the processing loop would always skip to invoke onCompleteFailure(), causing the callback to not be completed. Now we fall through and possibly invoke onCompleteFailure() if it was not already invoked. Updated javadocs. Code cleanups. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
joakime
reviewed
Dec 16, 2022
| /** | ||
| * Indicates that {@link #process()} has completed the overall job. | ||
| * Indicates that {@link #process()} has completed the whole | ||
| * iteration successfully. |
There was a problem hiding this comment.
+1 for the clearer javadoc on Action
sbordet
approved these changes
Dec 16, 2022
gregw
added a commit
that referenced
this pull request
Dec 20, 2022
Serialize onCompleteFailure for #9059 * Fixed case where process() throws an exception. Before, exiting the processing loop would always skip to invoke onCompleteFailure(), causing the callback to not be completed. Now we fall through and possibly invoke onCompleteFailure() if it was not already invoked. * Updated javadocs. * Code cleanups. Co-authored-by: Simone Bordet <simone.bordet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delay
onCompleteFailurecall until process has returned.