Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - On click of Allow push notifications fails #74

Closed
smaldd14 opened this issue May 27, 2021 · 12 comments · Fixed by #78
Closed

[BUG] - On click of Allow push notifications fails #74

smaldd14 opened this issue May 27, 2021 · 12 comments · Fixed by #78
Labels
confirmed bug A bug behavior that has been confirmed by maintainers help wanted Extra attention is needed

Comments

@smaldd14
Copy link

Hi, I've set up my iOS app to ask for permissions like so:
.JMModal(showModal: self.$showModal, for: [.locationAlways, .notification])
Allowing location successfully changes button to allowed, but allowing push notifications does not change the button to allowed, therefore, I cannot exit the modal.

However, I do see printouts in my appDelegate's didRegisterForRemoteNotificationsWithDeviceToken: saying that I have successfully registered? Everytime I click allow I see the button. I only see the Apple alert for allowing push notifications the very first time. But, button does not change to allowed.

To Reproduce
Steps to reproduce the behavior:

  1. Show JMModal with .locationAlways and .notification
  2. Allow Notifications
  3. See error

push notifications should change button to allowed and be able to dismiss.

Desktop (please complete the following information):

  • OS: iOS
  • Version 1.4

Smartphone (please complete the following information):

  • Device: iPhone 12 Pro device

Additional context
Add any other context about the problem here.

@smaldd14 smaldd14 added the possible bug Something isn't working label May 27, 2021
@smaldd14
Copy link
Author

By the way, I am absolutely loving this package and its ease of use! I am really am enjoying this, just wondering why notifications does not work??

@smaldd14
Copy link
Author

Also, as I'm testing more, I'm seeing if I stop the app from running AFTER I allow all notifications the first time, and then start the app again; when I get to the point when JMModal should show, it will not show (I'm assuming because all notifications have been allowed and JMModal recognizes that)

@macteuts
Copy link

Same here. Allowing notifications does nothing any longer. No more screen update. Though I also believe the notifications have actually been allowed (didn't check yet).
Also the "close" button doesn't closes.

@jevonmao
Copy link
Owner

@macteuts @smaldd14 Thank you very much for the bug report. I will look into the issue and try to reproduce it first. In the meantime, you might want to set restrictDismissal to false so it doesn't prevent user from dismissing the modal.

@jevonmao jevonmao added confirmed bug A bug behavior that has been confirmed by maintainers help wanted Extra attention is needed and removed possible bug Something isn't working labels May 29, 2021
@jevonmao
Copy link
Owner

@macteuts @smaldd14 The bug is confirmed, and after looking into it for a while, I cannot figure out the reason this is happening. I will continue to try to fix this, but if you are not using any 1.4.0 API, you should for now re-add the package 1.3.0 version which works perfectly and does not have this bug.

@gharary
Copy link

gharary commented Jun 7, 2021

Same here. Allowing notifications do nothing any longer.
Using 1.4.2 version.

@smaldd14
Copy link
Author

smaldd14 commented Jun 9, 2021

Any updates on this bug??

@jevonmao
Copy link
Owner

jevonmao commented Jun 9, 2021

@smaldd14 WWDC 2021 just announced the new async/await feature which will be very useful to resolving this bug. ETA 2-3 more days needed to fix and new version will be released. Thank you everyone for understanding.

jevonmao added a commit that referenced this issue Jun 9, 2021
@jevonmao
Copy link
Owner

jevonmao commented Jun 9, 2021

@macteuts @gharary @smaldd14 @fnazarios

Everyone, please try newest 1.4.3 version and see if it's fixed.

@macteuts
Copy link

macteuts commented Jun 9, 2021

will let you now asap. Thanks for the reactivity though

@smaldd14
Copy link
Author

smaldd14 commented Jun 9, 2021

@jevonmao in version 1.4.3, the notifications button successfully turns to 'Allowed', but the auto dismissal still does not happen.is this something you're aware of?

@jevonmao
Copy link
Owner

Closing for now because this is fixed and no further activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed bug A bug behavior that has been confirmed by maintainers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants