Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support service discovery servers to resolve service addresses #158

Merged
merged 4 commits into from
Nov 9, 2020

Conversation

azzz
Copy link
Contributor

@azzz azzz commented Oct 26, 2020

Includes the possibility to use service discovery implementations to resolve service addresses.

@azzz azzz force-pushed the feat/support-services-discovery branch 5 times, most recently from f7d9c50 to 6c83bad Compare October 27, 2020 09:18
@codecov-io
Copy link

codecov-io commented Oct 27, 2020

Codecov Report

Merging #158 (1a4ba00) into master (7a85a9b) will decrease coverage by 2.26%.
The diff coverage is 77.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
- Coverage   82.23%   79.97%   -2.27%     
==========================================
  Files         144      157      +13     
  Lines        6385     6713     +328     
==========================================
+ Hits         5251     5369     +118     
- Misses        761      957     +196     
- Partials      373      387      +14     
Impacted Files Coverage Δ
cmd/semaphore/daemon/providers/options.go 93.10% <0.00%> (-6.90%) ⬇️
cmd/semaphore/functions/strings/sprintf/sprintf.go 95.00% <0.00%> (ø)
pkg/broker/manager/flow.go 0.00% <0.00%> (ø)
pkg/broker/manager/options.go 0.00% <0.00%> (ø)
pkg/codec/xml/errors.go 100.00% <ø> (+10.00%) ⬆️
pkg/flow/flow.go 98.73% <0.00%> (ø)
pkg/providers/errors.go 100.00% <ø> (ø)
pkg/specs/services.go 100.00% <ø> (ø)
pkg/transport/protocol.go 100.00% <ø> (ø)
pkg/providers/providers.go 75.00% <8.33%> (-25.00%) ⬇️
... and 73 more

@azzz azzz force-pushed the feat/support-services-discovery branch 6 times, most recently from ccce5ea to b949e72 Compare November 2, 2020 12:43
website/sidebars.js Outdated Show resolved Hide resolved
examples/consul/Makefile Outdated Show resolved Hide resolved
examples/consul/README.md Outdated Show resolved Hide resolved
pkg/providers/hcl/services.go Outdated Show resolved Hide resolved
@jeroenrinzema jeroenrinzema added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 5, 2020
@azzz azzz force-pushed the feat/support-services-discovery branch from 62bda17 to 5a2d546 Compare November 6, 2020 09:42
@azzz azzz force-pushed the feat/support-services-discovery branch from 5ae09df to 1a4ba00 Compare November 9, 2020 09:39
@azzz azzz merged commit 8b32225 into jexia:master Nov 9, 2020
@azzz azzz deleted the feat/support-services-discovery branch November 9, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants