Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable Diffusion Image Size #32

Closed
jezs00 opened this issue Jan 21, 2023 · 5 comments
Closed

Stable Diffusion Image Size #32

jezs00 opened this issue Jan 21, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@jezs00
Copy link
Owner

jezs00 commented Jan 21, 2023

Check Stable diffusion works without resize and crops instead. Try to recreate #26 (comment) .

@recrudesce
Copy link
Contributor

Could you not just ask SD to generate the image based on the known epd screen size ?

@jezs00
Copy link
Owner Author

jezs00 commented Jan 21, 2023 via email

@jezs00 jezs00 added the bug Something isn't working label Jan 21, 2023
@jezs00
Copy link
Owner Author

jezs00 commented Jan 21, 2023

Issue is based on resize_image() in provider.py. This will resize the image to capture as much as possible of it on the screen, which works depending on the display, however if the factor of resize required for the short edge of the screen is smaller than the factor of resize required on the long edge, it will display black bars. Writing replacement function fit_image() to thumbnail on a factor, instead of just on longest edge.

@jezs00 jezs00 self-assigned this Jan 21, 2023
jezs00 pushed a commit that referenced this issue Jan 21, 2023
@jezs00
Copy link
Owner Author

jezs00 commented Jan 21, 2023

Should be fixed. Just testing on pi, then I'll bundle it into a release.

@jezs00
Copy link
Owner Author

jezs00 commented Jan 21, 2023

Appears to work. Closing for now and releasing new version.

@jezs00 jezs00 closed this as completed Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants