Major restructure/refactoring #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade omni schema version to `omni.2.1` due a number of incompatible schema changes:
- `'result_type'` -> `'type'`
- `'ignore_error_and_return_empty_str` -> `'ignore_error'`
- `'keep_leading_trailing_space'` -> `'no_trim'`
- Changed how we handle custom functions: previously we always use strings as in param type as well as result param
type. Not anymore, all types are supported for custom function in and out params.
- Changed the way how we package custom functions for extensions: previously we collect custom functions from all
extensions and then pass all of them to the extension that is used; This feels weird, now changed to only the custom
functions included in a particular extension are used in that extension.
- Deprecated/removed most of the custom functions in favor of using 'javascript'.
- A number of package renaming.
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 36 35 -1
Lines 1640 1439 -201
==========================================
- Hits 1640 1439 -201
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
omni.2.1due a number of incompatible schema changes:'result_type'->'type''ignore_error_and_return_empty_str->'ignore_error''keep_leading_trailing_space'->'no_trim'fixes #87, #89.
sorry for the largish PR. too hard / too lazy to tease it part.