Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support elm 0.19 #17

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Conversation

kachkaev
Copy link
Contributor

@kachkaev kachkaev commented Sep 17, 2018

This PR is a heads-up to my attempt to support Elm 0.19. The upgrade involves quite a lot of change from the way we execute node-elm-compiler to what we keep in fixtures.

Most of the tests pass, there are only one that needs some more work is path-to-elm. I'm temporary skipping it. Hope I'll find time to better document changes as well.

@kachkaev
Copy link
Contributor Author

All tests are now passing except those related to custom pathToElm. Opened rtfeldman/node-elm-compiler#78 to see if we can find a solution upstream.

@kachkaev
Copy link
Contributor Author

kachkaev commented Sep 18, 2018

Published @kachkaev/run-elm@3.0.0-beta.1, which includes all changes up to the last commit. The failing test in travis is related to a jumping new line in one of the errors messages, which did not occur before. I'll fix this later.

We also need to enable Travis tests for PRs in this repo. The ones in my fork pass: https://travis-ci.com/kachkaev/run-elm/builds/85100237.

@kachkaev
Copy link
Contributor Author

@jfairbank if you have a second, could you please go to https://travis-ci.org/jfairbank/run-elm/settings and enable Build pushed pull requests like this?

screen shot 2018-09-18 at 08 13 01

@jfairbank
Copy link
Owner

@kachkaev It's already enabled. GitHub services are deprecated, so I removed the Travis service and reinstalled it as a GitHub app. Maybe that will fix the problem? Try force pushing or something to trigger a build.

@kachkaev
Copy link
Contributor Author

Hmm it did not trigger...

@kachkaev kachkaev mentioned this pull request May 12, 2019
@brandly
Copy link

brandly commented Nov 5, 2019

what can we do here?

@kachkaev
Copy link
Contributor Author

kachkaev commented Nov 5, 2019

@brandly I got the fork working here a while ago:

Haven't looked at it for a while, so feel free to enhance it if needed.

@brandly
Copy link

brandly commented Nov 5, 2019

thanks for the quick reply! i'm interested in CLIs written in elm, and it looked like run-elm might be a good starting place. i might try to make sense of how elm-analyse does it, but i'll let you know if i end up using this. thanks again.

@brandly
Copy link

brandly commented Nov 5, 2019

Compilation failed
Compiling (1)-- TYPE MISMATCH ----------------------- src/RunElmMain157298357467829132220.elm

The 1st argument to `sendOutput` is not what I expect:

12|     ( (), sendOutput output )
                         ^^^^^^
This `output` value is a:

    List String -> String

But `sendOutput` needs the 1st argument to be:

    String

Detected problems in 1 module.

does the fork not support List String -> String? the docs still mention it.

@dimpase
Copy link

dimpase commented Nov 6, 2020

we have 0.19.1 meanwhile, any news here? run-elm is very useful for teaching purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants