#1236 - MSVC compile unit.api.exe

[jfalcou]

No description provided.

[DenisYaroshevskiy]

So far more or less OK. Please lemme know when you are done

[DenisYaroshevskiy]

What - msvc cannot deal with negative numbers?

[Tradias]

The problem is that a uniform_int_distribution<> of unsigned integral type should not be constructed from negative integers, as they will implicitly be converted to unsigned and become very large. Therefore, leading to a>b which is undefined behavior: https://en.cppreference.com/w/cpp/numeric/random/uniform_int_distribution/uniform_int_distribution

[jfalcou]

The proper fix is maybe to split the test between signed and unsigned.

[Tradias]

Here is the patch for the ICE in deinterleave_groups.cpp. Some of the inability to capture non-type template parameter in lambdas is certainly a common MSVC issue, but this piece of code is not valid C++:

[](auto a)
{
   some_func<a()>();
}
(std::integral_constant<int, 42>{});

and cannot be blamed on MSVC^^.

diff --git a/test/unit/api/regular/deinterleave_groups.cpp b/test/unit/api/regular/deinterleave_groups.cpp
index 09bd6393f..57378c37e 100644
--- a/test/unit/api/regular/deinterleave_groups.cpp
+++ b/test/unit/api/regular/deinterleave_groups.cpp
@@ -114,19 +114,20 @@ using less_test_types =  eve::test::wides < tts::types< std::int8_t, std::uint16
 TTS_CASE_TPL( "Check behavior of deinterleave on arithmetic data", less_test_types)
 <typename T>(tts::type<T>)
 {
-  constexpr std::ptrdiff_t max_fields_count = 5;
+  static constexpr std::ptrdiff_t max_fields_count = 5;
 
-  eve::detail::for_<1, 1, max_fields_count + 1>([](auto fields)
+  eve::detail::for_<1, 1, max_fields_count + 1>([&]<int Fields>(std::integral_constant<int, Fields>)
   {
     // maybe unsused for gcc bug
     static constexpr std::size_t max_group_size = (T::size() >= 64) ? 4 : T::size();
-    constexpr auto nn = std::countr_zero(max_group_size) + 1;
+    static constexpr auto nn = std::countr_zero(max_group_size) + 1;
+    static constexpr std::ptrdiff_t fields = Fields;
     eve::detail::for_<0, 1, nn>
     (
-      [&](auto group_size_log)
+      [&]<int Shift>(std::integral_constant<int, Shift>)
       {
-        constexpr auto gs = 1 << group_size_log();
-        deinterleave_groups_test<gs, fields(), T>();
+        static constexpr auto gs = 1 << Shift;
+        deinterleave_groups_test<gs, fields, T>();
       }
     );
   });

[jfalcou]

Great! Will add it to the current PR