FIX-896: product type support, convert range #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenisYaroshevskiy
force-pushed
the
FIX-896/product_type_support_4
branch
from
0224862
to
5beeba9
Compare
jfalcou
reviewed
Sep 4, 2021
jfalcou
approved these changes
Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still no product type support so far.
I have implemented
convertin a different way though which is a step.range_ref- a function that takes a reference to a range. By default just stores a pointer to the original one, ifusing non_owning = voidis specified will copy by value. Generally speaking, it's enough to just makeas_rangenon owning but it removes a bunch of extra type wrappers that don't do anything.<=>bug. THere is nooperator<=>for vector iterators, had to improvise.convertfor anyrelaxed_iteratorandrelaxed_range, not justeve::algo::iteratorzip_rangeno longer has traits attached! Insteadzipimmediately converts all of the members.This one will be fixed: #906
This one isn't be visible in any shape so far (after this patch): #880
There might be a case at some point, but it will need different traits for that. Let's wait for a usecase.