Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced undefined this.hexValue with defined hexValue #249

Merged

Conversation

Hochen97
Copy link
Contributor

@Hochen97 Hochen97 commented May 5, 2024

As detailed in #234 and #247, replaced this.hexValue in WyzeMeshLight.js setHue() function with hexValue, as this.hexValue is not defined in the file. This paradigm matches setSaturation(), where the exact same hexValue logic exists.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message that will be displayed on users' first pull request

@jfarmer08 jfarmer08 merged commit e261b9e into jfarmer08:main May 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants