Feat rerender markdown #274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add demo component based on StackBlitz
|
@jfcere anything missing in this? |
|
Hi @shanmukhateja, sorry I haven't had time yet ... looks pretty good at first glance, I'll try to look it further soon. |
|
Hey @jfcere not to rush but found time for this yet? |
|
Because some refactor has been done for ngx-markdown v14, there was a lot of conflicts with this PR. Also, I didn't have the rights to push back in the PR branch so I had to clone it and create a new PR. The re-render feature will be added and released into version 14 alongside the Angular 14 update that should be released next week. Thank you for your contribution and sorry for the huge delay and PR cloning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
reloadfunction toMarkdownServiceto manually re-render Markdown.Closes #122