Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move StyleTag to StylesEntry #24

Closed
jferard opened this issue Nov 22, 2016 · 2 comments
Closed

Move StyleTag to StylesEntry #24

jferard opened this issue Nov 22, 2016 · 2 comments
Milestone

Comments

@jferard
Copy link
Owner

jferard commented Nov 22, 2016

The StyleTag XML is written in content.xml > automatic-styles. That's the wrong destination, since FastODS does not allow anonymous styles. The output has to be moved to styles.xml > styles.

@jferard jferard modified the milestones: 0.2.1, 0.1.2 Nov 22, 2016
@jferard jferard added the bug label Nov 22, 2016
jferard added a commit that referenced this issue Nov 25, 2016
@jferard jferard closed this as completed Nov 25, 2016
@jferard
Copy link
Owner Author

jferard commented Nov 27, 2016

There are a lot of problems with that commit:

  • LO does not recognize common styles for rows, columns or text spans.
  • LO does not accept text family styles for page layout if those styles are not in Styles/automatic-styles.
  • A few other limitations.

A good rule of thumb: follow LO if possible, even if LO does not fully respect the specs.

@jferard
Copy link
Owner Author

jferard commented Dec 3, 2016

Fixed with the StylesContainer class, which centralizes the style definitions. Entries use it to write styles XML in the suitable place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant