Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special characters in test filenames causing issues with CI server #128

Closed
losttime opened this issue Feb 4, 2015 · 4 comments
Closed

Special characters in test filenames causing issues with CI server #128

losttime opened this issue Feb 4, 2015 · 4 comments

Comments

@losttime
Copy link
Contributor

losttime commented Feb 4, 2015

Jenkins has a problem clearing out the workspace if there are files with special characters. This tests triggers that problem: 檔案.html
@losttime losttime mentioned this issue Feb 4, 2015
Closed
@jfhbrook
Copy link
Owner

Ah Jenkins, why do you have to be the only piece of shit that isn't a TOTAL piece of shit?

@jfhbrook
Copy link
Owner

Can you make your jenkins build shell out to rm -rf that file instead?

@jfhbrook
Copy link
Owner

Also: Is there a corresponding issue for jenkins?

EDIT: Found http://jenkins-ci.361315.n4.nabble.com/Unable-to-delete-unicode-files-during-workspace-cleanup-td4642320.html which indicates this bug is over 2 years old. This doesn't look like an issues tracker, so it's hard to say if the bug has actually been addressed.

jfhbrook added a commit that referenced this issue Feb 16, 2015
@jfhbrook
Add .npmignore which ignores the tests directory
ebac68d 
In general, I think including tests with npm packages is good practice. It
allows developers to run tests against code that's currently installed on their
box if/when they think their dependencies are causing them problems. However,
it appears that jenkins barfs when trying to clean up workspaces where there
are unicode filenames.

See: #128

I'm less than thrilled about merging this, in part because the onus should, in
a perfect world, be on jenkins to fix this. Unfortunately, the real world isn't
so nice, and this is the path of least resistance in terms of allowing people
using jenkins to depend on ecstatic.

;_;
@jfhbrook
Copy link
Owner

I ended up merging #129 which "fixes" this by removing tests from the npm package. Extensive, self-indulging commentary here: ebac68d

@jfhbrook jfhbrook reopened this Feb 16, 2015
@hmil hmil mentioned this issue Oct 12, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include .npmignore file
2 participants
@jfhbrook @losttime