fix: response can be aborted during e.g. fs.stat and hasGzipId12 #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
force-pushed
the
fix-async-aborted-response
branch
2 times, most recently
from
2cffc9e
to
1d325bd
Compare
ronag
force-pushed
the
fix-async-aborted-response
branch
from
1d325bd
to
6853bea
Compare
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
- Coverage 75.31% 74.86% -0.45%
==========================================
Files 11 11
Lines 555 557 +2
Branches 126 127 +1
==========================================
- Hits 418 417 -1
- Misses 48 51 +3
Partials 89 89
Continue to review full report at Codecov.
|
|
I honestly have no idea how to fix the code coverage on this... |
ronag
changed the title
ronag
changed the title
|
I'm honestly not sure how to test this either, these kinda time-dependent things are tough! I say don't sweat the codecov report, I'm not 100% taking it to heart. |
Merged
|
I implemented this in the on-finished PR with onFinished.isFinished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request/Response can be aborted while doing async stuff... handle it.
Would prefer to use
isFinishedbut I've proposed using theon-finishedpackage in another PR so I'll leave the "modern" node way here.