v4.1.3: [security] Fix crash on redirect with formfeed in URL (CVE-2019-10775) #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…19-10775) This fixes CVE-2019-10775. I'll postpone regression tests because the request library cannot send those requests (crashing the client instead of ecstatic), so I'll need to find another module that can.
|
Thanks! |
|
out as 4.1.4 due to having to fuck with github actions but it should be out |
|
… and only now it comes to my mind that the RegExp should probably have matched U+0020 space as well. However the impact is probably limited to confusing readers of that code. I'll probably fix that once I get to write the tests for it. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for disturbing the peace of the dead, but I'd really appreciate you making an exception so I don't need to start a maintenance fork. (If you wish I do I might consider it though.)