Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to npm@3 #45

Open
jfhbrook opened this issue Nov 5, 2013 · 6 comments
Open

upgrade to npm@3 #45

jfhbrook opened this issue Nov 5, 2013 · 6 comments

Comments

@jfhbrook
Copy link
Collaborator

jfhbrook commented Nov 5, 2013

We should run npm dedupe for moar smallers bundles.

@kirbysayshi
Copy link

Doesn't browserify implicitly dedupe based on package contents?

@jfhbrook
Copy link
Collaborator Author

At this point? Possibly. If someone could confirm that would be great. @thlorenz might know.

@jamesplease
Copy link

Just fyi I'm going to be working on this – or something similar – this weekend. Right now it seems to be impossible to load Marionette.

The issue is that Backbone optionally supports jQuery, but doesn't explicitly require it. Marionette, on the other hand, has a hard dep on jQuery, but only references Backbone.$ when accessing it. Accordingly, to load Marionette, you must do:

var Backbone = require('backbone');
var $ = Backbone.$ = require('jquery');
var Marionette = require('backbone.marionette');

Right now, Marionette is pulling in its own Backbone and throwing an error. So I think deduping the dep tree will fix the problem.

@thlorenz
Copy link

browserify dedupes based on file contents.

@jfhbrook
Copy link
Collaborator Author

It's entirely possible that wzrd.in is running with an old version of browserify. Check the package.json and ask max about it.

@jamesplease
Copy link

I admit I'm not too familiar with Browserify's release history, but it seems like deduping was added in this PR, released as v5.12.1.

browserify-cdn relies on ^5.10.1, so if the above is correct, then fresh installs of browserify-cdn should pull in that release of browserify.

With that said, there have been 2 major releases of browserify since then. Nothing in the changelog mentions updates to deduping, but I have yet to check if simply updating the dep will fix this problem.

It's entirely possible that wzrd.in is running with an old version of browserify. Check the package.json and ask max about it.

Good suggestion, but I'm running my own instance of browserify-cdn and running into the same issue. My instance is using the latest 5.x release.

@jfhbrook jfhbrook changed the title dedupe upgrade to npm@3 Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants