This repository has been archived by the owner on Apr 2, 2021. It is now read-only.
jatom.js: fix 'link' population #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, the logic for finding the 'link' for an atom entry would just grab the first 'link'-type node from a given entry. But an entry may have multiple 'link' nodes; one needs to grab the '<link rel="alternate" ....' node. * http://www.xml.com/pub/a/2004/06/16/dive.html -> "Every Atom feed and every Atom entry needs an alternate link. It is the only type of link that is required by the Atom feed specification." An example feed that uses multiple 'link' nodes (emitted 'link' field is wrong before this change): * http://blog.racket-lang.org/feeds/posts/default
Fix jatom.js to adhere to RFC 4287 for 'link' population. Before this change, the logic for finding the 'link' for an atom entry would just grab the first 'link'-type node from a given entry. But an entry may have multiple 'link' nodes; one needs to grab the '<link rel="alternate" ....' node for that case. An example feed that uses multiple 'link' nodes (emitted 'link' field is wrong before this change): * http://blog.racket-lang.org/feeds/posts/default
|
The patch in simonsj/jFeed@2e5e4a8 is incomplete: link nodes are allowed to omit 'rel' attributes, in which case they're assumed to be 'alternate' links (RFC 4287; 4.2.7.2). simonsj/jFeed@9fca8c6 should correct the handling for both cases. |
scottishwildcat
added a commit
to scottishwildcat/rssmenu-safari
that referenced
this pull request
Nov 5, 2016
|
Closing as stale :). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix jatom.js to adhere to RFC 4287 for 'link' population.
Before this change, the logic for finding the 'link' for
an atom entry would just grab the first 'link'-type node
from a given entry. But an entry may have multiple 'link'
nodes; one needs to grab the '<link rel="alternate" ....'
node for that case.
An example feed that uses multiple 'link' nodes (emitted
'link' field is wrong before this change):