Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export System Properties listed in the white list #34

Closed
jfilak opened this issue Feb 19, 2014 · 4 comments
Closed

Export System Properties listed in the white list #34

jfilak opened this issue Feb 19, 2014 · 4 comments

Comments

@jfilak
Copy link
Owner

jfilak commented Feb 19, 2014

abrt-java-connector provides only the most important System Properties [1], but there are many other important properties that are required for successful resolution of reported bugs. For example icedtea-web developers needs to known URL which caused the exception [2].

For those who have concerns about the security issues, ABRT doesn't publish any data without a user's permission - users must review the published data and confirm that he wants to publish it, users are also allowed and encouraged to remove/modify security sensitive information.

1: http://docs.oracle.com/javase/tutorial/essential/environment/sysprop.html
2: https://bugzilla.redhat.com/show_bug.cgi?id=1060390

@judovana
Copy link

Although I will be happy to have custom property from ITW rpinted out, isnt it clsoe to spying?
Maybe some whitelist of allowed properties would be nice. But it si a lot of more work to currently simple app. MAybe itis not worthy.

@judovana
Copy link

judovana commented Mar 5, 2014

In environment with security manager and shared classloaders, the properties can be to public.
I have inclined to use private static field of String for this purpose. The whitelist then be package.class fieldName
What do you think?

@judovana
Copy link

judovana commented Mar 7, 2014

ok. Going on with private static string:method.

@jfilak
Copy link
Owner Author

jfilak commented Mar 7, 2014

Sure, go ahead! I was about to create a development branch with the initial implementation[1] when I saw your comment.

In the initial implementation, I prove that abrt-java-connector is able to call a static method of a loaded class. I have found out that abrt-java-connector must not use Class loader to get the class defining the required method because this approach cause that the method is called for every uncaught exception in any application. Performing the class look up in the list of already loaded classes drastically decreases the number of useless calls.

1: 271d00f

jfilak pushed a commit that referenced this issue Mar 13, 2014
Related to #34

Signed-off-by: Jakub Filak <jfilak@redhat.com>
jfilak pushed a commit that referenced this issue Mar 13, 2014
Related to #34

Signed-off-by: Jakub Filak <jfilak@redhat.com>
@jfilak jfilak closed this as completed in 7ff93da Mar 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants